linux-kernel - Re: [linus:master] [perf dsos] 7a9418cf7f: util/dsos.c:184:8: runtime error: null pointer passed as argument 2, which is declared to never be null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7cjzuJCGXLe_5Jzmcu2iiRtb07WwATnrz01sR7g++b6Frg@mail.gmail.com>
Date: Wed, 19 Jun 2024 14:37:13 -0400
From: Namhyung Kim <namhyung@...nel.org>
To: kernel test robot <oliver.sang@...el.com>
Cc: Ian Rogers <irogers@...gle.com>, oe-lkp@...ts.linux.dev, lkp@...el.com, 
	linux-kernel@...r.kernel.org, Arnaldo Carvalho de Melo <acme@...hat.com>, 
	Adrian Hunter <adrian.hunter@...el.com>, 
	Ahelenia Ziemiańska <nabijaczleweli@...ijaczleweli.xyz>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Andi Kleen <ak@...ux.intel.com>, 
	Athira Rajeev <atrajeev@...ux.vnet.ibm.com>, Ben Gainey <ben.gainey@....com>, 
	Changbin Du <changbin.du@...wei.com>, Chengen Du <chengen.du@...onical.com>, 
	Colin Ian King <colin.i.king@...il.com>, Dima Kogan <dima@...retsauce.net>, 
	Ilkka Koskinen <ilkka@...amperecomputing.com>, Ingo Molnar <mingo@...hat.com>, 
	James Clark <james.clark@....com>, Jiri Olsa <jolsa@...nel.org>, 
	K Prateek Nayak <kprateek.nayak@....com>, Kan Liang <kan.liang@...ux.intel.com>, 
	Leo Yan <leo.yan@...ux.dev>, Li Dong <lidong@...o.com>, Mark Rutland <mark.rutland@....com>, 
	Masami Hiramatsu <mhiramat@...nel.org>, Paran Lee <p4ranlee@...il.com>, 
	Peter Zijlstra <peterz@...radead.org>, Song Liu <song@...nel.org>, 
	Sun Haiyong <sunhaiyong@...ngson.cn>, Thomas Richter <tmricht@...ux.ibm.com>, 
	Tiezhu Yang <yangtiezhu@...ngson.cn>, Yanteng Si <siyanteng@...ngson.cn>, 
	zhaimingbing <zhaimingbing@...s.chinamobile.com>, linux-perf-users@...r.kernel.org
Subject: Re: [linus:master] [perf dsos] 7a9418cf7f: util/dsos.c:184:8: runtime
 error: null pointer passed as argument 2, which is declared to never be null

Hello,

On Mon, Jun 17, 2024 at 9:45 PM kernel test robot <oliver.sang@...el.com> wrote:
>
>
>
> Hello,
>
> kernel test robot noticed "util/dsos.c:184:8: runtime error: null pointer passed as argument 2, which is declared to never be null" on:
>
> commit: 7a9418cf7f05a74cbc9d4c750ee1bfddaa11f121 ("perf dsos: Switch hand crafted code to bsearch()")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>
> [test failed on linus/master      a3e18a540541325a8c8848171f71e0d45ad30b2c]
> [test failed on linux-next/master 6906a84c482f098d31486df8dc98cead21cce2d0]
>
>
>
> the issue can be reproduced by below commands:
>
> $ sudo make WERROR=0 ARCH= DEBUG=1 EXTRA_CFLAGS='-fno-omit-frame-pointer -fsanitize=undefined -fsanitize=address'
> $ sudo ./perf record  -e 'cpu/branch-instructions/' -- sleep 1
> util/dsos.c:184:8: runtime error: null pointer passed as argument 2, which is declared to never be null

It seems we need to return early from the function when
dsos->dsos is NULL since there's nothing to search.

Thanks,
Namhyung

>
>
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <oliver.sang@...el.com>
> | Closes: https://lore.kernel.org/oe-lkp/202406180932.84be448c-oliver.sang@intel.com
>
>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>
>