linux-kernel - RE: [PATCH 06/15] net: hbl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <BY3PR18MB473757A4F450A2F5C115D5A9C6CF2@BY3PR18MB4737.namprd18.prod.outlook.com>
Date: Wed, 19 Jun 2024 18:35:02 +0000
From: Sunil Kovvuri Goutham <sgoutham@...vell.com>
To: Omer Shpigelman <oshpigelman@...ana.ai>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>
CC: "ogabbay@...nel.org" <ogabbay@...nel.org>,
        "zyehudai@...ana.ai"
	<zyehudai@...ana.ai>
Subject: RE: [PATCH 06/15] net: hbl_cn: debugfs support


>+
>+What:           /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_disable_decap
>+What:           /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_inject_rx_err
>+What:           /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_mac_lane_remap

Don't think debugfs is the correct interface for all this configuration.
Debugfs should ideally be used for dumping runtime device state info for debug purposes.

>+What:           /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_mac_loopback

Why not use ethtool ?

>+
>+What:           /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_mmu_bypass

How does this work ?

Thanks,
Sunil.