linux-kernel - Re: [PATCH] mm: ratelimit oversized kvmalloc warnings instead of once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whXL32xG1HWGaVaOkHf+g407upYbvZeZgmhnsxn2R+JRQ@mail.gmail.com>
Date: Wed, 19 Jun 2024 12:30:42 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Shakeel Butt <shakeel.butt@...ux.dev>
Cc: Michal Hocko <mhocko@...e.com>, Andrew Morton <akpm@...ux-foundation.org>, kernel-team@...a.com, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
	Kyle McMartin <kyle@...radead.org>
Subject: Re: [PATCH] mm: ratelimit oversized kvmalloc warnings instead of once

On Wed, 19 Jun 2024 at 10:47, Shakeel Butt <shakeel.butt@...ux.dev> wrote:
>
> Linus, please let me know if you have any concerns on the approach
> Michal is suggesting i.e. a variant for warn once for unique call stack.

I think we should just try to change the existing WARN_ONCE(), and see
if it causes any issues.

A new "WARN_UNIQUE()" might be the borign and safe approach, but

 (a) it won't actually be unique if you don't have stackdepot anyway,
and will just be WARN_ONCE

 (b) I suspect most WARN_ONCE users really do want WARN_UNIQUE

so let's at least _start_ with just changing semantics of the existing
"once", and then if it causes problems we'll have to revisit this.

I doubt it will cause problems,

                Linus