linux-kernel - Re: [PATCH] dlm: use KMEM_CACHE() in dlm_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK-6q+jPMPoue9w+=_ZtEjE7AohRrbPHN93Fa=CbXtrTOyhicQ@mail.gmail.com>
Date: Wed, 19 Jun 2024 17:33:28 -0400
From: Alexander Aring <aahringo@...hat.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Hongfu Li <lihongfu@...inos.cn>, gfs2@...ts.linux.dev, 
	David Teigland <teigland@...hat.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dlm: use KMEM_CACHE() in dlm_memory_init()

Hi,

On Wed, Jun 19, 2024 at 4:54 PM Markus Elfring <Markus.Elfring@....de> wrote:
>
> > Using KMEM_CACHE() macro makes the code more concise and easy to read.
>
> Can the three passed name strings matter still for the identification
> of the created caches from this function implementation?
> https://elixir.bootlin.com/linux/v6.10-rc4/source/fs/dlm/memory.c#L27
> https://elixir.bootlin.com/linux/v6.10-rc4/source/mm/slab_common.c#L362

probably only for "dlm_cb" that turns into "dlm_callback". The only
place for me would be /proc/slabinfo, but I usually do `cat
/proc/slabinfo | grep dlm` to get an overview. If you are very strict
and "/proc/slabinfo" is not just "debugging" only and allowed to be
screen scraped (which I don't believe) it might can indeed break some
userspace applications.

- Alex