linux-kernel - [PATCH v2] module: Add log information for loading module failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240619083037.1070310-1-a869920004@gmail.com>
Date: Wed, 19 Jun 2024 08:30:37 +0000
From: Yusong Gao <a869920004@...il.com>
To: mcgrof@...nel.org
Cc: linux-modules@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	a869920004@...il.com
Subject: [PATCH v2] module: Add log information for loading module failures

Add log information in kernel-space when loading module failures.
Try to load the unsigned module and the module with bad signature
when set 1 to /sys/module/module/parameters/sig_enforce.

Unsigned module case:
(linux) insmod unsigned.ko
[   18.714661] Loading of unsigned module is rejected
insmod: can't insert 'unsigned.ko': Key was rejected by service
(linux)

Bad signature module case:
(linux) insmod bad_signature.ko
insmod: can't insert 'bad_signature.ko': Key was rejected by service
(linux)

There have different logging behavior the bad signature case only log
in user-space, add log info for fatal errors in module_sig_check().

Signed-off-by: Yusong Gao <a869920004@...il.com>
---
V2: Change print level from notice to debug.
---
 kernel/module/signing.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/module/signing.c b/kernel/module/signing.c
index a2ff4242e623..b0c7b30e4d89 100644
--- a/kernel/module/signing.c
+++ b/kernel/module/signing.c
@@ -113,6 +113,7 @@ int module_sig_check(struct load_info *info, int flags)
 		 * unparseable signatures, and signature check failures --
 		 * even if signatures aren't required.
 		 */
+		pr_debug("Loading module failed (errno=%d)\n", -err);
 		return err;
 	}
 
-- 
2.34.1