linux-kernel - Re: [net-next v1] net: wwan: t7xx: Add debug port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SYBP282MB3528ACDD0F9077C35ADE236BBBCF2@SYBP282MB3528.AUSP282.PROD.OUTLOOK.COM>
Date: Wed, 19 Jun 2024 18:08:38 +0800
From: Jinjian Song <songjinjian@...mail.com>
To: kuba@...nel.org,
	Vanillan Wang <songjinjian@...mail.com>
Cc: chandrashekar.devegowda@...el.com,
	chiranjeevi.rapolu@...ux.intel.com,
	davem@...emloft.net,
	edumazet@...gle.com,
	haijun.liu@...iatek.com,
	jinjian.song@...ocom.com,
	johannes@...solutions.net,
	linux-kernel@...r.kernel.org,
	loic.poulain@...aro.org,
	m.chetan.kumar@...ux.intel.com,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	ricardo.martinez@...ux.intel.com,
	ryazanov.s.a@...il.com
Subject: Re: [net-next v1] net: wwan: t7xx: Add debug port

From: Jakub Kicinski <kuba@...nel.org>

>On Fri, 14 Jun 2024 17:49:51 +0800 Vanillan Wang wrote:
>> From: Jinjian Song <jinjian.song@...ocom.com>
>> 
>> Add support for userspace to switch on the debug port(ADB,MIPC).
>>  - ADB port: /dev/ccci_sap_adb
>>  - MIPC port: /dev/ttyMIPC0
>> 
>> Switch on debug port:
>>  - debug: 'echo debug > /sys/bus/pci/devices/${bdf}/t7xx_mode
>> 
>> Switch off debug port:
>>  - normal: 'echo normal > /sys/bus/pci/devices/${bdf}/t7xx_mode
>
>You need to provide more detail on what it does and how it's used.
I will add more detail to that, thanks.

>> +	txq_mtu = t7xx_get_port_mtu(port);
>> +	if (txq_mtu < 0)
>> +		return -EINVAL;
>
>drivers/net/wwan/t7xx/t7xx_port_debug.c:153:5-12: WARNING: Unsigned expression compared with zero: txq_mtu < 0
>-- 
>
I will fix it, thanks

Jinjian,
Best Regards.