linux-kernel - linux-next: build failure after merge of the mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ZnLBrO71obXfwGkE@sirena.org.uk>
Date: Wed, 19 Jun 2024 12:31:56 +0100
From: Mark Brown <broonie@...nel.org>
To: Andrew Morton <akpm@...ux-foundation.org>,
	Oscar Salvador <osalvador@...e.de>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: linux-next: build failure after merge of the mm tree

Hi all,

After merging the mm tree, today's linux-next build (arm64 defconfig)
failed like this:

/tmp/next/build/mm/hugetlb_cgroup.c: In function 'hugetlb_cgroup_cfttypes_init':
/tmp/next/build/mm/hugetlb_cgroup.c:840:42: error: 'struct cftype' has no member named 'lockdep_key'
  840 |                 lockdep_register_key(&cft->lockdep_key);
      |                                          ^~
make[4]: *** [/tmp/next/build/scripts/Makefile.build:244: mm/hugetlb_cgroup.o] Error 1

Caused by commit

  eb9290991cb59 ("mm/hugetlb_cgroup: register lockdep key for cftype")


From 2de1726235b66fe778f30b53532baaa48b284f8c Mon Sep 17 00:00:00 2001
From: Mark Brown <broonie@...nel.org>
Date: Wed, 19 Jun 2024 12:21:59 +0100
Subject: [PATCH] mm: Fix build failure due to missing build time check

/tmp/next/build/mm/hugetlb_cgroup.c: In function 'hugetlb_cgroup_cfttypes_init':
/tmp/next/build/mm/hugetlb_cgroup.c:840:42: error: 'struct cftype' has no member named 'lockdep_key'
  840 |                 lockdep_register_key(&cft->lockdep_key);
      |                                          ^~

Signed-off-by: Mark Brown <broonie@...nel.org>
---
 mm/hugetlb_cgroup.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
index 4ff238ba12503..369431160a0a8 100644
--- a/mm/hugetlb_cgroup.c
+++ b/mm/hugetlb_cgroup.c
@@ -837,7 +837,9 @@ hugetlb_cgroup_cfttypes_init(struct hstate *h, struct cftype *cft,
 					   MEMFILE_FIELD_SIZE(offset) * idx;
 		}
 
+#ifdef CONFIG_DEBUG_LOCK_ALLOC
 		lockdep_register_key(&cft->lockdep_key);
+#endif
 	}
 }
 
-- 
2.39.2


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)