linux-kernel - Re: [PATCH 3/5] arm64: dts: rockchip: Fix mic-in-differential usage on rk3568-rock-3a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4015ded1-5ec4-4374-982e-9c7f23b43884@collabora.com>
Date: Wed, 19 Jun 2024 15:56:37 +0300
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Jonas Karlman <jonas@...boo.se>, Lee Jones <lee@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Chris Zhong <zyw@...k-chips.com>, Zhang Qing <zhangqing@...k-chips.com>,
 Chris Morgan <macromorgan@...mail.com>,
 Furkan Kardame <f.kardame@...jaro.org>,
 Michael Riesch <michael.riesch@...fvision.net>
Cc: kernel@...labora.com, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] arm64: dts: rockchip: Fix mic-in-differential usage
 on rk3568-rock-3a

Hi Jonas,

On 6/19/24 3:22 PM, Jonas Karlman wrote:
> Hi Cristian,
> 
> On 2024-06-19 13:23, Cristian Ciocaltea wrote:
>> The 'mic-in-differential' DT property supported by the RK809/RK817 audio
>> codec driver is actually valid if prefixed with 'rockchip,':
>>
>>   DTC_CHK arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb
>>   rk3568-rock-3a.dtb: pmic@20: codec: 'mic-in-differential' does not match any of the regexes: 'pinctrl-[0-9]+'
>> 	from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml#
>>
>> Make use of the correct property name.
>>
>> Fixes: a84ffd2ef1ff ("arm64: dts: rockchip: Fix mic-in-differential usage on rock-3a")
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
>> ---
>>  arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
>> index ebdedea15ad1..0b54dfe92d6e 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
>> @@ -533,7 +533,7 @@ regulator-state-mem {
>>  		};
>>  
>>  		codec {
>> -			mic-in-differential;
>> +			rockchip,mic-in-differential;
> 
> If I understand the schematics correctly, only one wire is connected so
> this board cannot really use differential signaling, and this should
> probably instead be dropped.

Thanks for pointing this out, I will drop it in v2.

Regards,
Cristian