[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <95b10d88-be5b-4fcb-a30b-414dc90d18fe@kwiboo.se>
Date: Wed, 19 Jun 2024 17:05:49 +0200
From: Jonas Karlman <jonas@...boo.se>
To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>, Lee Jones
<lee@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner
<heiko@...ech.de>, Chris Zhong <zyw@...k-chips.com>, Zhang Qing
<zhangqing@...k-chips.com>, Chris Morgan <macromorgan@...mail.com>, Furkan
Kardame <f.kardame@...jaro.org>, Michael Riesch
<michael.riesch@...fvision.net>
Cc: kernel@...labora.com, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] dt-bindings: mfd: rk809: Add missing audio codec
properties
Hi Cristian,
On 2024-06-19 14:53, Cristian Ciocaltea wrote:
> Hi Jonas,
>
> On 6/19/24 3:20 PM, Jonas Karlman wrote:
>> Hi Cristian,
>>
>> On 2024-06-19 13:23, Cristian Ciocaltea wrote:
>>> The RK809 MFD provides a RK817 compatible audio codec, supported by the
>>> rk817_codec driver.
>>>
>>> This has been already in use by several boards: rk3566-quartz64-b,
>>> k3566-roc-pc, rk3568-evb1-v10, rk3568-lubancat-2, rk3568-odroid-m1,
>>> rk3568-rock-3a. However, dtbs_check fails for all of them:
>>>
>>> DTC_CHK arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb
>>> rk3568-rock-3a.dtb: pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', 'clock-names', 'clocks', 'codec' do not match any of the regexes: 'pinctrl-[0-9]+'
>>> from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml#
>>>
>>> Document the missing audio codec properties as found on the
>>> rockchip,rk817 schema.
>>
>> This is duplicate of "dt-bindings: mfd: rk809: Add audio codec properties"
>> part of "arm64: dts: rockchip: Add Radxa ROCK 3B" series.
>>
>> https://lore.kernel.org/all/20240505134120.2828885-3-jonas@kwiboo.se/
>>
>> A v2 of that series with fixes for reported issues is imminent.
>> How do you want me to preceded with such v2 series?
>
> Oh, it seems both of us made the same mistake and wrongly assumed the
> rockchip,rk817 schema is good enough to be used as a reference. :-)
Hehe, yeah :-)
>
> Since both rockchip,rk817 and rockchip,rk809 files share most of the
> content, I also think this might be a good opportunity to get them
> merged into a single schema.
>
> I can do this in v2, unless you prefer to handle it as part of your series.
I was planning on sending the following, merging the schemas may also be
an option.
https://github.com/Kwiboo/linux-rockchip/compare/619509e6c853...next-20240618-rock-3b-orangepi-3b/
Main purpose of my series was to add ROCK 3B and also Orange Pi 3B,
fixing rockchip,rk809 binding is just a prerequisite.
If you want to merge the bindings, please do :-), I can wait a few more
days to send out a ROCK 3B + Orange Pi 3B v2 series.
Please also include the vcc8/9 fix if you send a v2.
Regards,
Jonas
>
> Thanks,
> Cristian
Powered by blists - more mailing lists