| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20240620-nvmem-compat-name-v1-5-700e17ba3d8f@weissschuh.net> Date: Thu, 20 Jun 2024 18:00:37 +0200 From: Thomas Weißschuh <linux@...ssschuh.net> To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Jiri Prchal <jiri.prchal@...ignal.cz> Cc: linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Thomas Weißschuh <linux@...ssschuh.net> Subject: [PATCH 5/5] nvmem: core: drop unnecessary range checks in sysfs callbacks The same checks have already been done in sysfs_kf_bin_write() and sysfs_kf_bin_read() just before the callbacks are invoked. Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net> --- drivers/nvmem/core.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index ed077d7e3998..5c1ee7f0da0a 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -203,19 +203,12 @@ static ssize_t bin_attr_nvmem_read(struct file *filp, struct kobject *kobj, dev = kobj_to_dev(kobj); nvmem = to_nvmem_device(dev); - /* Stop the user from reading */ - if (pos >= nvmem->size) - return 0; - if (!IS_ALIGNED(pos, nvmem->stride)) return -EINVAL; if (count < nvmem->word_size) return -EINVAL; - if (pos + count > nvmem->size) - count = nvmem->size - pos; - count = round_down(count, nvmem->word_size); if (!nvmem->reg_read) @@ -243,19 +236,12 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj, dev = kobj_to_dev(kobj); nvmem = to_nvmem_device(dev); - /* Stop the user from writing */ - if (pos >= nvmem->size) - return -EFBIG; - if (!IS_ALIGNED(pos, nvmem->stride)) return -EINVAL; if (count < nvmem->word_size) return -EINVAL; - if (pos + count > nvmem->size) - count = nvmem->size - pos; - count = round_down(count, nvmem->word_size); if (!nvmem->reg_write) -- 2.45.2
Powered by blists - more mailing lists