linux-kernel - Re: [PATCH v12 3/7] iio: core: Add new DMABUF interface infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca3efef9-9720-46be-a59d-a9a4c5873ea2@web.de>
Date: Thu, 20 Jun 2024 18:32:48 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: lkp@...el.com, Paul Cercueil <paul@...pouillou.net>,
 Nuno Sá <nuno.sa@...log.com>, linux-iio@...r.kernel.org,
 dmaengine@...r.kernel.org, linux-media@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org,
 Christian König <christian.koenig@....com>,
 Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>,
 Sumit Semwal <sumit.semwal@...aro.org>, Vinod Koul <vkoul@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>,
 linux-doc@...r.kernel.org, Jonathan Corbet <corbet@....net>,
 Julia Lawall <julia.lawall@...ia.fr>, Lee Jones <lee@...nel.org>,
 Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v12 3/7] iio: core: Add new DMABUF interface
 infrastructure

…
> v11:
…
>     - Use guard(mutex)
>
> v12:
>     - Revert to mutex_lock/mutex_unlock in iio_buffer_attach_dmabuf(),
>       as it uses cleanup GOTOs
…

I would find it nice if better design options could gain acceptance.
Will the chances grow to adjust scopes another bit for involved variables
in such function implementations?

A) Enclosing a source code part with extra curly brackets?

B) scoped_guard()?
   https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/cleanup.h#L137

C) Moving a locked source code part into a separate function implementation?


Regards,
Markus