linux-kernel - Re: [PATCH v12 3/7] iio: core: Add new DMABUF interface infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240620165543.GR3029315@google.com>
Date: Thu, 20 Jun 2024 17:55:43 +0100
From: Lee Jones <lee@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: lkp@...el.com, Paul Cercueil <paul@...pouillou.net>,
	Nuno Sá <nuno.sa@...log.com>,
	linux-iio@...r.kernel.org, dmaengine@...r.kernel.org,
	linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	linaro-mm-sig@...ts.linaro.org,
	Christian König <christian.koenig@....com>,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Sumit Semwal <sumit.semwal@...aro.org>,
	Vinod Koul <vkoul@...nel.org>, oe-kbuild-all@...ts.linux.dev,
	LKML <linux-kernel@...r.kernel.org>, linux-doc@...r.kernel.org,
	Jonathan Corbet <corbet@....net>,
	Julia Lawall <julia.lawall@...ia.fr>,
	Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v12 3/7] iio: core: Add new DMABUF interface
 infrastructure

On Thu, 20 Jun 2024, Markus Elfring wrote:

> …
> > v11:
> …
> >     - Use guard(mutex)
> >
> > v12:
> >     - Revert to mutex_lock/mutex_unlock in iio_buffer_attach_dmabuf(),
> >       as it uses cleanup GOTOs
> …
> 
> I would find it nice if better design options could gain acceptance.
> Will the chances grow to adjust scopes another bit for involved variables
> in such function implementations?
> 
> A) Enclosing a source code part with extra curly brackets?
> 
> B) scoped_guard()?
>    https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/cleanup.h#L137
> 
> C) Moving a locked source code part into a separate function implementation?

I think it would help your cause if you quoted the exact piece of code
you're referring to.  Then tone down the language a bit - keep it as
simple and natural as you can.

Ex 1: Please place curly brackets around this section to aid with <reason>

Ex 2: To save N lines of clean-up, please use scoped_guard()

Ex 3: Moving out this chunk to another function would help with <reason>

Etc.

-- 
Lee Jones [李琼斯]