linux-kernel - Re: [PATCH] ubifs: add check for crypto_shash_tfm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12a768cb-8ced-0b59-59f3-b05833e41bf3@huawei.com>
Date: Thu, 20 Jun 2024 14:14:22 +0800
From: Zhihao Cheng <chengzhihao1@...wei.com>
To: Chen Ni <nichen@...as.ac.cn>, <richard@....at>, <ebiggers@...gle.com>,
	<herbert@...dor.apana.org.au>
CC: <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ubifs: add check for crypto_shash_tfm_digest

在 2024/6/20 11:45, Chen Ni 写道:
> Add check for the return value of crypto_shash_tfm_digest() and return
> the error if it fails in order to catch the error.
> 
> Fixes: f80df3851246 ("ubifs: use crypto_shash_tfm_digest()")

I think the fix tag should 
817aa094842dfc3a6b98c9582d4a647827f66201("ubifs: support offline signed 
images"), otherwise:
Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>

> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>   fs/ubifs/master.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/ubifs/master.c b/fs/ubifs/master.c
> index 7adc37c10b6a..a148760fa49e 100644
> --- a/fs/ubifs/master.c
> +++ b/fs/ubifs/master.c
> @@ -67,10 +67,13 @@ static int mst_node_check_hash(const struct ubifs_info *c,
>   {
>   	u8 calc[UBIFS_MAX_HASH_LEN];
>   	const void *node = mst;
> +	int ret;
>   
> -	crypto_shash_tfm_digest(c->hash_tfm, node + sizeof(struct ubifs_ch),
> +	ret = crypto_shash_tfm_digest(c->hash_tfm, node + sizeof(struct ubifs_ch),
>   				UBIFS_MST_NODE_SZ - sizeof(struct ubifs_ch),
>   				calc);
> +	if (ret)
> +		return ret;
>   
>   	if (ubifs_check_hash(c, expected, calc))
>   		return -EPERM;
>