linux-kernel - Re: [PATCH v2 3/7] hwrng: exynos: Use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63e4f095-6558-4cb1-a189-60d1d3cc6ec3@kernel.org>
Date: Thu, 20 Jun 2024 09:29:00 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sam Protsenko <semen.protsenko@...aro.org>,
 Łukasz Stelmach <l.stelmach@...sung.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: Anand Moon <linux.amoon@...il.com>, Olivia Mackall <olivia@...enic.com>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 Alim Akhtar <alim.akhtar@...sung.com>, linux-samsung-soc@...r.kernel.org,
 linux-crypto@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/7] hwrng: exynos: Use devm_clk_get_enabled() to get
 the clock

On 18/06/2024 22:45, Sam Protsenko wrote:
> Use devm_clk_get_enabled() helper instead of calling devm_clk_get() and
> then clk_prepare_enable(). It simplifies the error handling and makes
> the code more compact. Also use dev_err_probe() to handle possible
> -EPROBE_DEFER errors if the clock is not available yet.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@...aro.org>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof