linux-kernel - Re: [PATCH v3] mfd: axp20x: AXP717: Fix missing IRQ status registers range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240620092753.GG3029315@google.com>
Date: Thu, 20 Jun 2024 10:27:53 +0100
From: Lee Jones <lee@...nel.org>
To: Andre Przywara <andre.przywara@....com>
Cc: Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>,
	linux-kernel@...r.kernel.org, linux-sunxi@...ts.linux.dev,
	Chris Morgan <macroalpha82@...il.com>,
	Ryan Walklin <ryan@...ttoast.com>,
	Philippe Simons <simons.philippe@...il.com>
Subject: Re: [PATCH v3] mfd: axp20x: AXP717: Fix missing IRQ status registers
 range

On Fri, 14 Jun 2024, Andre Przywara wrote:

> While we list the "IRQ status *and acknowledge*" registers as volatile
> in the MFD description, they are missing from the writable range array,
> so acknowledging any interrupts was met with an -EIO error.
> This error propagates up, leading to the whole AXP717 driver failing to
> probe, which is fatal to most systems using this PMIC, since most
> peripherals refer one of the PMIC voltage rails.
> This wasn't noticed on the initial submission, since the interrupt was
> completely missing at this point, but the DTs now merged describe the
> interrupt, creating the problem.
> 
> Add the five registers that hold those bits to the writable array.
> 
> This fixes the boot on the Anbernic systems using the AXP717 PMIC.
> 
> Fixes: b5bfc8ab2484 ("mfd: axp20x: Add support for AXP717 PMIC")
> Reported-by: Chris Morgan <macromorgan@...mail.com>
> Signed-off-by: Andre Przywara <andre.przywara@....com>
> ---
> Hi,
> 
> the patch itself is unchanged from v2 sent in April, but the commit
> message was updated to give rationale for the Fixes: tag.
> Please take this as a fix into v6.10.
> 
> Thanks,
> Andre
> 
>  drivers/mfd/axp20x.c | 1 +
>  1 file changed, 1 insertion(+)

Submitted to Linus today.

-- 
Lee Jones [李琼斯]