linux-kernel - Re: [PATCH] media: i2c: Kconfig: Fix missing firmware upload config select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240620103335.GA27999@pendragon.ideasonboard.com>
Date: Thu, 20 Jun 2024 13:33:35 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Paul Elder <paul.elder@...asonboard.com>,
	Hans Verkuil <hverkuil-cisco@...all.nl>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	thomas.petazzoni@...tlin.com,
	Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH] media: i2c: Kconfig: Fix missing firmware upload config
 select

Hi Kory,

Thank you for the patch.

On Thu, Jun 20, 2024 at 12:25:43PM +0200, Kory Maincent wrote:
> FW_LOADER config only selects the firmware loader API, but we also need
> the sysfs_upload symbols for firmware_upload_unregister() and
> firmware_upload_register() to function properly.
> 
> Fixes: 7a52ab415b43 ("media: i2c: Add driver for THine THP7312")
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/media/i2c/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index c6d3ee472d81..742bc665602e 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -679,6 +679,7 @@ config VIDEO_THP7312
>  	tristate "THine THP7312 support"
>  	depends on I2C
>  	select FW_LOADER
> +	select FW_UPLOAD
>  	select MEDIA_CONTROLLER
>  	select V4L2_CCI_I2C
>  	select V4L2_FWNODE

-- 
Regards,

Laurent Pinchart