[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZnQfVX5bbmDSsFlK@pyrite.rasen.tech>
Date: Thu, 20 Jun 2024 21:23:49 +0900
From: Paul Elder <paul.elder@...asonboard.com>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Hans Verkuil <hverkuil-cisco@...all.nl>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
thomas.petazzoni@...tlin.com,
Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH] media: i2c: Kconfig: Fix missing firmware upload config
select
On Thu, Jun 20, 2024 at 12:25:43PM +0200, Kory Maincent wrote:
> FW_LOADER config only selects the firmware loader API, but we also need
> the sysfs_upload symbols for firmware_upload_unregister() and
> firmware_upload_register() to function properly.
>
> Fixes: 7a52ab415b43 ("media: i2c: Add driver for THine THP7312")
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
Reviewed-by: Paul Elder <paul.elder@...asonboard.com>
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index c6d3ee472d81..742bc665602e 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -679,6 +679,7 @@ config VIDEO_THP7312
> tristate "THine THP7312 support"
> depends on I2C
> select FW_LOADER
> + select FW_UPLOAD
> select MEDIA_CONTROLLER
> select V4L2_CCI_I2C
> select V4L2_FWNODE
> --
> 2.34.1
>
>
Powered by blists - more mailing lists