[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZnQizwOWjsIbj6TR@e133380.arm.com>
Date: Thu, 20 Jun 2024 13:38:39 +0100
From: Dave Martin <Dave.Martin@....com>
To: Borislav Petkov <bp@...en8.de>
Cc: linux-tip-commits@...r.kernel.org,
Reinette Chatre <reinette.chatre@...el.com>, x86@...nel.org,
linux-kernel@...r.kernel.org
Subject: Re: [tip: x86/urgent] x86/resctrl: Don't try to free nonexistent
RMIDs
On Thu, Jun 20, 2024 at 01:53:05PM +0200, Borislav Petkov wrote:
> On Thu, Jun 20, 2024 at 12:36:43PM +0100, Dave Martin wrote:
> > I guess my issue is that the "Massage commit message" seems to document
> > a criticism that the author was careless, didn't follow a rule, or that
> > the commit message was defective in some way, with the author having no
> > right of reply (at least, not recorded in the git history).
>
> Not necessarily - that's what you said. I massage commit messages because they
> need some touch ups sometimes.
>
> In your case I rewrote the sentence with "we" because "we" is ambiguous in
That _was_ unintentional, so apologies for that.
> commit messages. I also broke up this biggish paragraph into smaller chunks to
> make it more readable.
>
> > I may just be being too touchy.
> >
> > Anyway, thanks for picking up the patch -- I'm not trying to make extra
> > work for anyone.
>
> I look at it this way: I don't always agree with other maintainers' choices
> either but this is the reality: every maintainer has their own
> requirements/views/etc on how the code and commit messages are going to look,
> yadda yadda. And to some extent that's their prerogative.
>
> But we have a *lot* *bigger* fish to fry so I'm going to stop debating here as
> everything was already said.
>
> Thx.
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
>
Ack; apologies for the noise.
Cheers
---Dave
Powered by blists - more mailing lists