linux-kernel - Re: [PATCH v1] net: dsa: mv88e6xxx: Add FID map cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 20 Jun 2024 22:40:28 +0800
From: kernel test robot <lkp@...el.com>
To: Aryan Srivastava <aryan.srivastava@...iedtelesis.co.nz>,
	Andrew Lunn <andrew@...n.ch>,
	Marek Behún <kabel@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev,
	Aryan Srivastava <aryan.srivastava@...iedtelesis.co.nz>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] net: dsa: mv88e6xxx: Add FID map cache

Hi Aryan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]
[also build test WARNING on net/main linus/master v6.10-rc4 next-20240619]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Aryan-Srivastava/net-dsa-mv88e6xxx-Add-FID-map-cache/20240620-083100
base:   net-next/main
patch link:    https://lore.kernel.org/r/20240620002826.213013-1-aryan.srivastava%40alliedtelesis.co.nz
patch subject: [PATCH v1] net: dsa: mv88e6xxx: Add FID map cache
config: arm-randconfig-003-20240620 (https://download.01.org/0day-ci/archive/20240620/202406202033.cdjd66Gh-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240620/202406202033.cdjd66Gh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406202033.cdjd66Gh-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/dsa/mv88e6xxx/chip.c: In function 'mv88e6xxx_atu_new':
>> drivers/net/dsa/mv88e6xxx/chip.c:1960:13: warning: unused variable 'err' [-Wunused-variable]
    1960 |         int err;
         |             ^~~


vim +/err +1960 drivers/net/dsa/mv88e6xxx/chip.c

  1957	
  1958	static int mv88e6xxx_atu_new(struct mv88e6xxx_chip *chip, u16 *fid)
  1959	{
> 1960		int err;
  1961	
  1962		*fid = find_first_zero_bit(chip->fid_bitmap, MV88E6XXX_N_FID);
  1963		if (unlikely(*fid >= mv88e6xxx_num_databases(chip)))
  1964			return -ENOSPC;
  1965	
  1966		/* Clear the database */
  1967		return mv88e6xxx_g1_atu_flush(chip, *fid, true);
  1968	}
  1969	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki