linux-kernel - Re: [PATCH v7 1/1] nvme-multipath: implement "queue-depth" iopolicy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b09f3db4-df3a-4dce-a490-32b38e97231a@redhat.com>
Date: Thu, 20 Jun 2024 10:41:22 -0400
From: John Meneghini <jmeneghi@...hat.com>
To: Christoph Hellwig <hch@....de>
Cc: kbusch@...nel.org, sagi@...mberg.me, linux-nvme@...ts.infradead.org,
 linux-kernel@...r.kernel.org, emilne@...hat.com, jrani@...estorage.com,
 randyj@...estorage.com, chaitanyak@...dia.com, hare@...nel.org
Subject: Re: [PATCH v7 1/1] nvme-multipath: implement "queue-depth" iopolicy

On 6/20/24 02:56, Christoph Hellwig wrote:
>> +		WARN_ON_ONCE((atomic_dec_if_positive(&ns->ctrl->nr_active)) < 0);
> Overly long line.
> 
> But I don't understand why you need the WARN_ON anyway.  If the value
> must always be positive there is no point in atomic_dec_if_positive.
> If misaccounting is fine there WARN_ON is counterproductive.

Agreed. I wanted this here for testing purposes.  In all of my hours of running tests I never saw this warning go off, so I 
agree it should be removed.

/John