linux-kernel - Re: [PATCH v14 2/6] media: imagination: Add E5010 JPEG Encoder driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8dda9d0c-3154-a7fd-1233-ca5be59639de@ti.com>
Date: Fri, 21 Jun 2024 18:14:16 +0530
From: Devarsh Thakkar <devarsht@...com>
To: Sebastian Fricke <sebastian.fricke@...labora.com>
CC: <mchehab@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <hverkuil-cisco@...all.nl>,
        <linux-media@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-rockchip@...ts.infradead.org>,
        <benjamin.gaignard@...labora.com>, <laurent.pinchart@...asonboard.com>,
        <praneeth@...com>, <nm@...com>, <vigneshr@...com>, <a-bhatia1@...com>,
        <j-luthra@...com>, <b-brnich@...com>, <detheridge@...com>,
        <p-mantena@...com>, <vijayp@...com>, <andrzej.p@...labora.com>,
        <nicolas@...fresne.ca>, <afd@...com>
Subject: Re: [PATCH v14 2/6] media: imagination: Add E5010 JPEG Encoder driver

Hi Sebastian

On 21/06/24 18:07, Sebastian Fricke wrote:
> Hey Devarsh,
> 
> This doesn't compile without errors for me, curious, it probably did
> compile without problems for you right?
> 
> drivers/media/platform/imagination/e5010-jpeg-enc.c:1622:19: error:
> initialization of ‘int (*)(struct platform_device *)’ from incompatible
> pointer type ‘void (*)(struct platform_device *)’
> [-Werror=incompatible-pointer-types]
>  1622 |         .remove = e5010_remove,
>       |                   ^~~~~~~~~~~~
> drivers/media/platform/imagination/e5010-jpeg-enc.c:1622:19: note: (near
> initialization for ‘e5010_driver.remove’)
> cc1: some warnings being treated as errors
> 

Yes I think it did compile fine for me.
Did you try this on tip of linux-next ?

As mentioned in changelog, there was update in platform driver for return type
of remove function which got changed to void return type. Please check if you
have this patch [1] in your tree which got recently merged.

Kindly let me know if you still face any issues.

[1]:
https://lore.kernel.org/all/20240527083416.1177106-2-u.kleine-koenig@pengutronix.de/

Regards
Devarsh