linux-kernel - Re: [PATCH v14 2/6] media: imagination: Add E5010 JPEG Encoder driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 15:26:58 +0200
From: Sebastian Fricke <sebastian.fricke@...labora.com>
To: Devarsh Thakkar <devarsht@...com>
Cc: mchehab@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, hverkuil-cisco@...all.nl,
	linux-media@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
	benjamin.gaignard@...labora.com, laurent.pinchart@...asonboard.com,
	praneeth@...com, nm@...com, vigneshr@...com, a-bhatia1@...com,
	j-luthra@...com, b-brnich@...com, detheridge@...com,
	p-mantena@...com, vijayp@...com, andrzej.p@...labora.com,
	nicolas@...fresne.ca, afd@...com
Subject: Re: [PATCH v14 2/6] media: imagination: Add E5010 JPEG Encoder driver

Hey Devarsh,

On 21.06.2024 18:14, Devarsh Thakkar wrote:
>Hi Sebastian
>
>On 21/06/24 18:07, Sebastian Fricke wrote:
>> Hey Devarsh,
>>
>> This doesn't compile without errors for me, curious, it probably did
>> compile without problems for you right?
>>
>> drivers/media/platform/imagination/e5010-jpeg-enc.c:1622:19: error:
>> initialization of ‘int (*)(struct platform_device *)’ from incompatible
>> pointer type ‘void (*)(struct platform_device *)’
>> [-Werror=incompatible-pointer-types]
>>  1622 |         .remove = e5010_remove,
>>       |                   ^~~~~~~~~~~~
>> drivers/media/platform/imagination/e5010-jpeg-enc.c:1622:19: note: (near
>> initialization for ‘e5010_driver.remove’)
>> cc1: some warnings being treated as errors
>>
>
>Yes I think it did compile fine for me.
>Did you try this on tip of linux-next ?

Nope the media subsystem is not based on linux-next, but instead on:
https://git.linuxtv.org/media_stage.git/log/
Please make sure that your patches compile on top of that.

>
>As mentioned in changelog, there was update in platform driver for return type
>of remove function which got changed to void return type. Please check if you
>have this patch [1] in your tree which got recently merged.

No that patch is not part of the tree yet.

Please note also the following section in that patch:

  	/*
	 * Traditionally the remove callback returned an int which however is
	 * ignored by the driver core. This led to wrong expectations by driver
	 * authors who thought returning an error code was a valid error
	 * handling strategy. To convert to a callback returning void, new
	 * drivers should implement .remove_new() until the conversion it done
	 * that eventually makes .remove() return void.

So your driver is expected to implement remove_new().

I will take care of this for the PR, but please note for the future:
It has to work with media_stage, unless you have a very good reason for
something different.

>
>Kindly let me know if you still face any issues.
>
>[1]:
>https://lore.kernel.org/all/20240527083416.1177106-2-u.kleine-koenig@pengutronix.de/
>
>Regards
>Devarsh

Regards,
Sebastian