linux-kernel - 回复: [PATCH v4 08/13] staging: media: starfive: Add for StarFive ISP 3A SC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 01:41:41 +0000
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Hans Verkuil <hverkuil-cisco@...all.nl>, Mauro Carvalho Chehab
	<mchehab@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Matthias Brugger <matthias.bgg@...il.com>, Ming Qian <ming.qian@....com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, Nicolas Dufresne
	<nicolas.dufresne@...labora.com>, Benjamin Gaignard
	<benjamin.gaignard@...labora.com>, Tomi Valkeinen
	<tomi.valkeinen+renesas@...asonboard.com>, Mingjia Zhang
	<mingjia.zhang@...iatek.com>, Marvin Lin <milkfafa@...il.com>
CC: Jack Zhu <jack.zhu@...rfivetech.com>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-staging@...ts.linux.dev"
	<linux-staging@...ts.linux.dev>
Subject:
 回复: [PATCH v4 08/13] staging: media: starfive: Add for StarFive ISP 3A SC

Hi, Hans,

Thanks for your comment

[...]
> > +static int video_scd_queue_setup(struct vb2_queue *q,
> > +				 unsigned int *num_buffers,
> > +				 unsigned int *num_planes,
> > +				 unsigned int sizes[],
> > +				 struct device *alloc_devs[])
> > +{
> 
> This still needs:
> 
>         if (*nplanes)
>                 return sizes[0] < sizeof(struct jh7110_isp_sc_buffer) ?
> -EINVAL : 0;
> 

Will add this.

> for proper VIDIOC_CREATEBUFS support.
> 
> Otherwise this will probably fail with 'v4l2-compliance -s'.
> 
[...]

Regards,
Changhuang