linux-kernel - 回复: [PATCH v4 11/13] staging: media: starfive: Add ISP params video device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <ZQ0PR01MB130298ADCD73E4E0E05230C1F2C92@ZQ0PR01MB1302.CHNPR01.prod.partner.outlook.cn>
Date: Fri, 21 Jun 2024 01:55:13 +0000
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Hans Verkuil <hverkuil-cisco@...all.nl>, Mauro Carvalho Chehab
	<mchehab@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Matthias Brugger <matthias.bgg@...il.com>, Ming Qian <ming.qian@....com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, Nicolas Dufresne
	<nicolas.dufresne@...labora.com>, Benjamin Gaignard
	<benjamin.gaignard@...labora.com>, Tomi Valkeinen
	<tomi.valkeinen+renesas@...asonboard.com>, Mingjia Zhang
	<mingjia.zhang@...iatek.com>, Marvin Lin <milkfafa@...il.com>
CC: Jack Zhu <jack.zhu@...rfivetech.com>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-staging@...ts.linux.dev"
	<linux-staging@...ts.linux.dev>
Subject:
 回复: [PATCH v4 11/13] staging: media: starfive: Add ISP params video device

Hi, Hans

Thanks for your comments.

[...]
> > +static int stf_isp_params_queue_setup(struct vb2_queue *q,
> > +				      unsigned int *num_buffers,
> > +				      unsigned int *num_planes,
> > +				      unsigned int sizes[],
> > +				      struct device *alloc_devs[]) {
> 
> Add:
> 
>         if (*nplanes)
>                 return sizes[0] < sizeof(struct jh7110_isp_params_buffer ?
> -EINVAL : 0;
> 

Will add this.

> > +	*num_planes = 1;
> > +	sizes[0] = sizeof(struct jh7110_isp_params_buffer);
> > +
> > +	return 0;
> > +}
> > +
[...]
> > +static const struct v4l2_file_operations stf_isp_params_fops = {
> > +	.owner          = THIS_MODULE,
> > +	.unlocked_ioctl = video_ioctl2,
> > +	.open           = v4l2_fh_open,
> > +	.release        = vb2_fop_release,
> > +	.poll           = vb2_fop_poll,
> > +	.mmap           = vb2_fop_mmap,
> > +	.read           = vb2_fop_read,
> 
> This isn't needed since no read support is indicated in q->io_modes.
> 

Wil drop read support.

> Note: I see that this is also set in stf_vid_fops, but it can be dropped there as
> well. Please make a separate patch for that change.
> 

Will add a new patch drop read support in stf_vid_fops.

Regards,
Changhuang