linux-kernel - 回复: [PATCH v4 01/13] media: starfive: Add JH7110 ISP module definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <ZQ0PR01MB1302CAD4A6F9DB486793DD95F2DA2@ZQ0PR01MB1302.CHNPR01.prod.partner.outlook.cn>
Date: Mon, 8 Jul 2024 13:14:03 +0000
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Hans Verkuil <hverkuil-cisco@...all.nl>, Mauro Carvalho Chehab
	<mchehab@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Matthias Brugger <matthias.bgg@...il.com>, Ming Qian <ming.qian@....com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, Nicolas Dufresne
	<nicolas.dufresne@...labora.com>, Benjamin Gaignard
	<benjamin.gaignard@...labora.com>, Tomi Valkeinen
	<tomi.valkeinen+renesas@...asonboard.com>, Mingjia Zhang
	<mingjia.zhang@...iatek.com>, Marvin Lin <milkfafa@...il.com>
CC: Jack Zhu <jack.zhu@...rfivetech.com>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-staging@...ts.linux.dev"
	<linux-staging@...ts.linux.dev>
Subject:
 回复: [PATCH v4 01/13] media: starfive: Add JH7110 ISP module definitions

Hi Hans,

Thanks for your comments. 

> 
> Hi Changhuang,
> 
> Have you checked that these structs have the same layout for 32 and 64
> architectures?
> pahole is a useful tool for that.
> 
> I.e., if the kernel is 64 bit but userspace is compiled for 32 bit, then these
> structs should still have the same layout.
> 
> It probably is fine, checking it with pahole is a good idea.
> 

I tested the 32 and 64 architectures using pahole, they have the same layout.
Thanks for pointing out the spelling error, I will check all the spelling and fix them.

Regards,
Changhuang