linux-kernel - RE: [PATCH v20 17/18] x86/resctrl: Sub-NUMA Cluster (SNC) detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB60838E655CB373A762F66851FCC92@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Fri, 21 Jun 2024 17:14:14 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: Markus Elfring <Markus.Elfring@....de>, "x86@...nel.org" <x86@...nel.org>,
	Babu Moger <babu.moger@....com>, Dave Martin <Dave.Martin@....com>, "Drew
 Fustini" <dfustini@...libre.com>, "Yu, Fenghua" <fenghua.yu@...el.com>,
	"James Morse" <james.morse@....com>, "Wieczor-Retman, Maciej"
	<maciej.wieczor-retman@...el.com>, Peter Newman <peternewman@...gle.com>,
	"Chatre, Reinette" <reinette.chatre@...el.com>
CC: LKML <linux-kernel@...r.kernel.org>, "patches@...ts.linux.dev"
	<patches@...ts.linux.dev>
Subject: RE: [PATCH v20 17/18] x86/resctrl: Sub-NUMA Cluster (SNC) detection

> > Add the missing definition of pr_fmt() to monitor.c. …
>
> How do you think about to add the tag “Fixes” accordingly?

Until this patch there were only "can't happen" pr_info()/pr_warn()
messages. So no real benefit from having this backported.

If it were to be backported, would need to split this out from the
rest of this patch as the rest of the changes are dependent on
on the previous 16 patches in this series.

> > +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
> …
> > +static __init int snc_get_config(void)
> > +{
> …
> > +   cpus_read_lock();
> > +   if (num_online_cpus() != num_present_cpus())
> > +           pr_warn("Some CPUs offline, SNC detection may be incorrect\n");
> > +   cpus_read_unlock();
> …
>
> Would you become interested to apply a statement like “guard(cpus_read_lock)();”?
> https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/cleanup.h#L133

IMHO it would be better to convert resctrl to using the cleanup.h helpers
as a separate series rather than having just one place use it.

-Tony