linux-kernel - Re: [PATCH 6/8] clk: qcom: Add support for Display clock Controllers on SA8775P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <053e047b-7594-48bc-ac1b-2368c0c8f1cc@quicinc.com>
Date: Fri, 21 Jun 2024 10:03:57 +0530
From: Taniya Das <quic_tdas@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Stephen
 Boyd" <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bartosz Golaszewski
	<bartosz.golaszewski@...aro.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_jkona@...cinc.com>, <quic_imrashai@...cinc.com>
Subject: Re: [PATCH 6/8] clk: qcom: Add support for Display clock Controllers
 on SA8775P



On 6/13/2024 10:16 PM, Konrad Dybcio wrote:
> 
> 
> On 6/12/24 12:47, Taniya Das wrote:
>> Add support for display0 and display1 clock controllers on SA8775P
>> platform.
>>
>> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
>> ---
> 
> Please merge this into one to save on boilerplate, take a look
> at dispcc-sc8280xp.c
> 

I did take a look at the dispcc for SC8280XP before posting the series, 
but it kind of looked tricky to add fixes for a particular dispcc.
Debugging could also be difficult in my opinion.
Though I understand that we are trying to optimize by re-using few 
common structures/probe but from clocks side they are all redefined.
That was the reason to keep them separate.

> Konrad

-- 
Thanks & Regards,
Taniya Das.