linux-kernel - Re: [PATCH 1/8] dt-bindings: clock: qcom: Add SA8775P video clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 08:41:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Taniya Das <quic_tdas@...cinc.com>, Bjorn Andersson
 <andersson@...nel.org>, Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org>,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 quic_jkona@...cinc.com, quic_imrashai@...cinc.com
Subject: Re: [PATCH 1/8] dt-bindings: clock: qcom: Add SA8775P video clock
 controller

On 21/06/2024 06:24, Taniya Das wrote:
> 
> 
> On 6/13/2024 12:58 PM, Krzysztof Kozlowski wrote:
>> On 12/06/2024 12:47, Taniya Das wrote:
>>> Add device tree bindings for the video clock controller on Qualcomm
>>> SA8775P platform.
>>
>> You claim it is a v1, but I saw it and already commented on this. No
>> changelog, no versioning, so my comments were ignored?
>>
>> Please go back to previous comments, implement then, respond and then
>> send v3 with all comments addressed.
>>
> 
> Krzysztof, I mentioned the below in the cover letter of this series. Did 
> I still miss something?
> 
> Add support for videocc, camcc, dispcc0 and dispcc1 on Qualcomm SA8775P
> platform.
> 
> These multimedia clock controller and device tree patches are split
> from the below series.
> https://lore.kernel.org/all/20240531090249.10293-1-quic_tdas@quicinc.com/

But this does not invalidate patch history. If you sent patch in foo
patchset, then sending v2 of this patch in bar patchset is still v2, not
v1. You still need changelog and proper versioning.

So again - respond to previous comments and/or implement them, then
provide changelog what happened.

Best regards,
Krzysztof