linux-kernel - Re: [PATCH v3] staging: vc04_services: vchiq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 08:41:31 +0200
From: Stefan Wahren <wahrenst@....net>
To: Kieran Bingham <kieran.bingham@...asonboard.com>,
 Umang Jain <umang.jain@...asonboard.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 linux-rpi-kernel@...ts.infradead.org
Cc: Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Dan Carpenter <dan.carpenter@...aro.org>,
 Yang Li <yang.lee@...ux.alibaba.com>,
 "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
 <linux-arm-kernel@...ts.infradead.org>,
 "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] staging: vc04_services: vchiq_arm: Fix initialisation
 check

Am 21.06.24 um 00:10 schrieb Kieran Bingham:
> The vchiq_state used to be obtained through an accessor which would
> validate that the VCHIQ had been initialised correctly with the remote,
> or return a null state.
>
> In commit 42a2f6664e18 ("staging: vc04_services: Move global g_state to
> vchiq_state") the global state was moved to the vchiq_mgnt structures
> stored as a vchiq instance specific context. This conversion removed the
> helpers and instead replaced users of this helper with the assumption
> that the state is always available and the remote connected.
>
> The conversion does ensure that the state is always available, so some
> remaining state null pointer checks that remain are unnecessary, but the
> assumption that the remote is present and initialised is incorrect.
>
> Fix this broken assumption by re-introducing the logic that was lost
> during the conversion.
>
> Fixes: 42a2f6664e18 ("staging: vc04_services: Move global g_state to vchiq_state")
> Signed-off-by: Kieran Bingham <kieran.bingham@...asonboard.com>
>

Reviewed-by: Stefan Wahren <wahrenst@....net>

Thanks