linux-kernel - Re: [Patch v4 04/10] ARM: dts: lpc32xx: Add missing dma and i2s properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23a12b79-b3ac-47a1-9bc3-73a62f96e60f@kernel.org>
Date: Fri, 21 Jun 2024 08:20:43 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Piotr Wojtaszczyk <piotr.wojtaszczyk@...esys.com>,
 Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, "J.M.B. Downing" <jonathan.downing@...tel.com>,
 Vladimir Zapolskiy <vz@...ia.com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Russell King <linux@...linux.org.uk>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Arnd Bergmann <arnd@...db.de>, Yangtao Li <frank.li@...o.com>,
 Li Zetao <lizetao1@...wei.com>, Michael Ellerman <mpe@...erman.id.au>,
 Chancel Liu <chancel.liu@....com>, dmaengine@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, alsa-devel@...a-project.org,
 linuxppc-dev@...ts.ozlabs.org, linux-sound@...r.kernel.org,
 linux-clk@...r.kernel.org, linux-i2c@...r.kernel.org,
 linux-mtd@...ts.infradead.org
Cc: Markus Elfring <Markus.Elfring@....de>
Subject: Re: [Patch v4 04/10] ARM: dts: lpc32xx: Add missing dma and i2s
 properties

On 20/06/2024 19:56, Piotr Wojtaszczyk wrote:
> Adds properties declared in the new DT bindings:
>  - nxp,lpc3220-i2s.yaml
>  - nxp,lpc3220-dmamux.yaml
> for dma router/mux and I2S interface.
> 
> Signed-off-by: Piotr Wojtaszczyk <piotr.wojtaszczyk@...esys.com>

You are doing here multiple things at once. This should be

One patch is dma properties.

>  
>  			i2s0: i2s@...94000 {
>  				compatible = "nxp,lpc3220-i2s";
>  				reg = <0x20094000 0x1000>;
> +				interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clk LPC32XX_CLK_I2S0>;
> +				dmas = <&dma 0 1>, <&dma 13 1>;
> +				dma-names = "rx", "tx";
> +				#sound-dai-cells = <0>;

Sound dai cells is another patch (or entire node is separate patch).

>  				status = "disabled";
>  			};
>  
> @@ -231,12 +255,19 @@ sd: sd@...98000 {
>  					     <13 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk LPC32XX_CLK_SD>;
>  				clock-names = "apb_pclk";
> +				dmas = <&dma 4 1>;
> +				dma-names = "rx";
>  				status = "disabled";
>  			};
>  
>  			i2s1: i2s@...9c000 {
>  				compatible = "nxp,lpc3220-i2s";
>  				reg = <0x2009c000 0x1000>;
> +				interrupts = <23 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clk LPC32XX_CLK_I2S1>;
> +				dmas = <&dma 2 1>, <&dmamux 10 1 1>;
> +				dma-names = "rx", "tx";
> +				#sound-dai-cells = <0>;
>  				status = "disabled";
>  			};
>  
> @@ -312,21 +343,27 @@ fab {
>  			compatible = "simple-bus";
>  			ranges = <0x20000000 0x20000000 0x30000000>;
>  
> -			/* System Control Block */
> -			scb {
> -				compatible = "simple-bus";
> -				ranges = <0x0 0x40004000 0x00001000>;
> +			syscon@...04000 {
> +				compatible = "nxp,lpc3220-creg", "syscon", "simple-mfd";
> +				reg = <0x40004000 0x114>;

This hunk is also separate patch.

Best regards,
Krzysztof