linux-kernel - Re: [Patch v4 05/10] clk: lpc32xx: initialize regmap using parent syscon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 08:21:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Piotr Wojtaszczyk <piotr.wojtaszczyk@...esys.com>,
 Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, "J.M.B. Downing" <jonathan.downing@...tel.com>,
 Vladimir Zapolskiy <vz@...ia.com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Russell King <linux@...linux.org.uk>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Arnd Bergmann <arnd@...db.de>, Yangtao Li <frank.li@...o.com>,
 Li Zetao <lizetao1@...wei.com>, Michael Ellerman <mpe@...erman.id.au>,
 Chancel Liu <chancel.liu@....com>, dmaengine@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, alsa-devel@...a-project.org,
 linuxppc-dev@...ts.ozlabs.org, linux-sound@...r.kernel.org,
 linux-clk@...r.kernel.org, linux-i2c@...r.kernel.org,
 linux-mtd@...ts.infradead.org
Cc: Markus Elfring <Markus.Elfring@....de>
Subject: Re: [Patch v4 05/10] clk: lpc32xx: initialize regmap using parent
 syscon

On 20/06/2024 19:56, Piotr Wojtaszczyk wrote:
>  
> -	base = of_iomap(np, 0);
> -	if (!base) {
> -		pr_err("failed to map system control block registers\n");
> -		return;
> -	}
> -
> -	clk_regmap = regmap_init_mmio(NULL, base, &lpc32xx_scb_regmap_config);
> +	clk_regmap = syscon_node_to_regmap(np->parent);
>  	if (IS_ERR(clk_regmap)) {
>  		pr_err("failed to regmap system control block: %ld\n",
>  			PTR_ERR(clk_regmap));
> -		iounmap(base);

This looks backwards incompatible. You should keep the fallback way.

Best regards,
Krzysztof