linux-kernel - Re: [PATCH 1/2] workqueue: add io priority to work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJhGHyASBtZ6pE3hUB=qB7qv3CQ=OAwarxNaQ=iojcFznfORpg@mail.gmail.com>
Date: Fri, 21 Jun 2024 16:00:43 +0800
From: Lai Jiangshan <jiangshanlai@...il.com>
To: Yi Sun <yi.sun@...soc.com>
Cc: sunyibuaa@...il.com, tj@...nel.org, jaegeuk@...nel.org, chao@...nel.org, 
	ebiggers@...gle.com, kent.overstreet@...ux.dev, linux-kernel@...r.kernel.org, 
	linux-f2fs-devel@...ts.sourceforge.net, niuzhiguo84@...il.com, 
	Hao_hao.Wang@...soc.com, yunlongxing23@...il.com
Subject: Re: [PATCH 1/2] workqueue: add io priority to work_struct

Hello

On Fri, Jun 21, 2024 at 2:27 PM Yi Sun <yi.sun@...soc.com> wrote:

> index 4c38824f3ab4..d9969596bbc3 100644
> --- a/include/linux/workqueue_types.h
> +++ b/include/linux/workqueue_types.h
> @@ -17,6 +17,12 @@ struct work_struct {
>         atomic_long_t data;
>         struct list_head entry;
>         work_func_t func;
> +       /* If the work does submit_bio, io priority may be needed. */
> +       unsigned short ioprio;
> +       /* Record kworker's original io priority. */
> +       unsigned short ori_ioprio;
> +       /* Whether the work has set io priority? */
> +       long ioprio_flag;

I don't see any ioprio code being integrated into workqueue in your
patchset, from which what you need might be:

struct ioprio_work {
       /******* the work item to be scheduled *******/
       struct work_struct work;

       /******* the stuff need for ioprio ******/

       /* If the work does submit_bio, io priority may be needed. */
       unsigned short ioprio;
       /* Record kworker's original io priority. */
       unsigned short ori_ioprio;
       /* Whether the work has set io priority? */
       long ioprio_flag;
}

And if ioprio needs to be integrated into workqueue, it should be attributes
added to the workqueue itself as in the struct workqueue_attrs.

Thanks
Lai