linux-kernel - Re: [PATCH] rtla/osnoise: set the default threshold to 1us

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <101b0854-7b39-486d-af63-4fe72566e8e1@kernel.org>
Date: Fri, 21 Jun 2024 10:00:52 +0200
From: Daniel Bristot de Oliveira <bristot@...nel.org>
To: "Luis Claudio R. Goncalves" <lgoncalv@...hat.com>,
 Steven Rostedt <rostedt@...dmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH] rtla/osnoise: set the default threshold to 1us

Hi Luis,

This is not rtla/osnoise but tracing/osnoise, so the Subject would be:

[PATCH] tracing/osnoise: Set the default threshold to 1 us

On 6/10/24 15:23, Luis Claudio R. Goncalves wrote:
> Change the default threshold for osnoise to 1us, so that any noise
> equal or above this value is recorded. Let the user set a higher
> threshold if necessary.

The reason why I place fear instead of one was "fear" of having the loop
taking more then one us, creating false noise notifications because of
execution time.

But it actually never happened, even on low speed arm boxes... Also,
all users I know are setting it to 1 on rtla... so I think it is safe to
move the value to 1.

Acked-by: Daniel Bristot de Oliveira <bristot@...nel.org>

> Suggested-by: Daniel Bristot de Oliveira <bristot@...nel.org>
> Reviewed-by: Clark Williams <williams@...hat.com>
> Signed-off-by: Luis Claudio R. Goncalves <lgoncalv@...hat.com>
> ---
>  Documentation/trace/osnoise-tracer.rst | 2 +-
>  kernel/trace/trace_osnoise.c           | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/trace/osnoise-tracer.rst b/Documentation/trace/osnoise-tracer.rst
> index 140ef2533d26a..a520adbd34765 100644
> --- a/Documentation/trace/osnoise-tracer.rst
> +++ b/Documentation/trace/osnoise-tracer.rst
> @@ -108,7 +108,7 @@ The tracer has a set of options inside the osnoise directory, they are:
>     option.
>   - tracing_threshold: the minimum delta between two time() reads to be
>     considered as noise, in us. When set to 0, the default value will
> -   be used, which is currently 5 us.
> +   be used, which is currently 1 us.
>   - osnoise/options: a set of on/off options that can be enabled by
>     writing the option name to the file or disabled by writing the option
>     name preceded with the 'NO\_' prefix. For example, writing
> diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c
> index a8e28f9b9271c..66a871553d4a1 100644
> --- a/kernel/trace/trace_osnoise.c
> +++ b/kernel/trace/trace_osnoise.c
> @@ -1444,9 +1444,9 @@ static int run_osnoise(void)
>  	save_osn_sample_stats(osn_var, &s);
>  
>  	/*
> -	 * if threshold is 0, use the default value of 5 us.
> +	 * if threshold is 0, use the default value of 1 us.
>  	 */
> -	threshold = tracing_thresh ? : 5000;
> +	threshold = tracing_thresh ? : 1000;
>  
>  	/*
>  	 * Apply PREEMPT and IRQ disabled options.