lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 21 Jun 2024 10:26:11 +0200
From: Daniel Bristot de Oliveira <bristot@...nel.org>
To: John Kacur <jkacur@...hat.com>,
 "Luis Claudio R. Goncalves" <lgoncalv@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Clark Williams
 <williams@...hat.com>, linux-trace-kernel@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtla/osnoise: Better report when histogram is empty

On 6/12/24 16:12, John Kacur wrote:
>> +		/* There are samples above the threshold */
> IMHO The comment isn't needed because the variable had_samples is 
> descriptive, but it's not a big deal either

Yeah, I would not do it too, but it is fine.

I am adding it to my queue.

Thanks Luis and John!
-- Daniel

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ