linux-kernel - Re: [PATCH] leds: cros_ec: Implement review comments from Lee

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cef01f01-ccb8-43f5-af78-e59c8286976b@t-8ch.de>
Date: Fri, 21 Jun 2024 12:44:29 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Lee Jones <lee@...nel.org>
Cc: Pavel Machek <pavel@....cz>, Benson Leung <bleung@...omium.org>, 
	Guenter Roeck <groeck@...omium.org>, linux-leds@...r.kernel.org, chrome-platform@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: cros_ec: Implement review comments from Lee

On 2024-06-21 11:40:38+0000, Lee Jones wrote:
> On Thu, 20 Jun 2024, Thomas Weißschuh wrote:
> 
> > On 2024-06-20 18:15:11+0000, Lee Jones wrote:
> > > On Thu, 20 Jun 2024, Thomas Weißschuh wrote:
> > > 
> > > > On 2024-06-20 13:27:41+0000, Lee Jones wrote:
> > > > > On Thu, 20 Jun 2024, Thomas Weißschuh wrote:
> > > > > 
> > > > > > Hi Lee,
> > > > > > 
> > > > > > On 2024-06-20 10:31:14+0000, Lee Jones wrote:
> > > > > > > Definitely not seen a commit message like that before
> > > > > > 
> > > > > > I assumed that this patch would be squashed into the original commit.
> > > > > > 
> > > > > > My question in which form you wanted the changes should have included
> > > > > > "incremental series".
> > > > > 
> > > > > Incremental means on top.
> > > > > 
> > > > > A lot of maintainers don't support history re-writes, but I've reserved
> > > > > that right since forever, so I can squash it if you like.
> > > > 
> > > > If it is already visible somewhere and a squash would inconvenience
> > > > anybody I'll resend it.
> > > > But if not I'd be happy about a squash.
> > > > 
> > > > (I couldn't and still can't find the public tree where driver is in)
> > > 
> > > Odd, neither can I!  Okay applied the whole set again, squashed the
> > > patch and submitted for testing.
> > 
> > Thanks!
> > 
> > FYI:
> > 
> > The Ack you asked for in the cros_kbd_led_backlight series [0],
> > which should go through the LED tree (and has a MFD component),
> > was given by Tzung-Bi in [1].
> > 
> > (In case it fell through the cracks. If not, please disregard)
> 
> Now I'm really confused.
> 
> This patch not for that set though, right?
> 
> You're talking about:
> 
>  mfd: cros_ec: Register keyboard backlight subdevice
>  platform/chrome: cros_kbd_led_backlight: allow binding through MFD     <-- this one
>  leds: class: Add flag to avoid automatic renaming of LED devices
>  leds: class: Warn about name collisions earlier
> 
> But this fix-up patch belongs in:
> 
>  mfd: cros_ec: Register LED subdevice
>  leds: Add ChromeOS EC driver                                           <-- this one
>  leds: core: Unexport led_colors[] array
>  leds: multicolor: Use led_get_color_name() function
>  leds: core: Introduce led_get_color_name() function
> 
> Right?

Yes, all correct.
Which is why I referred to it explicitly as the "cros_kbd_led_backlight series".

It was meant as a heads-up. Mentioned here as I was writing with you anyways.

> > [0] https://lore.kernel.org/lkml/20240526-cros_ec-kbd-led-framework-v3-0-ee577415a521@weissschuh.net/
> > [1] https://lore.kernel.org/lkml/ZmutW6vh7pD1HLf5@google.com/