linux-kernel - RE: [PATCH] net: stmmac: Add a barrier to make sure all access coherent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 21 Jun 2024 10:53:51 +0000
From: Sunil Kovvuri Goutham <sgoutham@...vell.com>
To: WangYuli <wangyuli@...ontech.com>,
        "alexandre.torgue@...s.st.com"
	<alexandre.torgue@...s.st.com>,
        "joabreu@...opsys.com"
	<joabreu@...opsys.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org"
	<kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "guanwentao@...ontech.com"
	<guanwentao@...ontech.com>,
        Wang Zhimin <wangzhimin1179@...tium.com.cn>,
        Li
 Wencheng <liwencheng@...tium.com.cn>,
        Chen Baozi <chenbaozi@...tium.com.cn>,
        Wang Yinfeng <wangyinfeng@...tium.com.cn>
Subject: RE:  [PATCH] net: stmmac: Add a barrier to make sure all access
 coherent


>Besides, increase the ring buffer size to avoid buffer overflow.
>
>  */
> #define DMA_MIN_TX_SIZE		64
> #define DMA_MAX_TX_SIZE		1024
>-#define DMA_DEFAULT_TX_SIZE	512
>+#define DMA_DEFAULT_TX_SIZE	1024
> #define DMA_MIN_RX_SIZE		64
> #define DMA_MAX_RX_SIZE		1024
>-#define DMA_DEFAULT_RX_SIZE	512
>+#define DMA_DEFAULT_RX_SIZE	1024
> #define STMMAC_GET_ENTRY(x, size)	((x + 1) & (size - 1))
>

If this is a fix, please add a fixes tag.

                /* Prefetch the next RX descriptor */
                rx_q->cur_rx = STMMAC_GET_ENTRY(rx_q->cur_rx,
                                                priv->dma_conf.dma_rx_size);

Also do please elaborate buffer overflow problem.
Is this ' DMA_DEFAULT_RX_SIZE ' descriptor size or size of full descriptor ring ?

Thanks,
Sunil.