linux-kernel - Re: [PATCH] net: stmmac: Add a barrier to make sure all access coherent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f36c1c1-b561-49a7-82a7-a0aaef60cf83@lunn.ch>
Date: Fri, 21 Jun 2024 17:20:09 +0200
From: Andrew Lunn <andrew@...n.ch>
To: WangYuli <wangyuli@...ontech.com>
Cc: alexandre.torgue@...s.st.com, joabreu@...opsys.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	mcoquelin.stm32@...il.com, netdev@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	guanwentao@...ontech.com,
	Wang Zhimin <wangzhimin1179@...tium.com.cn>,
	Li Wencheng <liwencheng@...tium.com.cn>,
	Chen Baozi <chenbaozi@...tium.com.cn>,
	Wang Yinfeng <wangyinfeng@...tium.com.cn>
Subject: Re: [PATCH] net: stmmac: Add a barrier to make sure all access
 coherent

On Fri, Jun 21, 2024 at 06:18:36PM +0800, WangYuli wrote:
> Add a memory barrier to sync TX descriptor to avoid data error.
> Besides, increase the ring buffer size to avoid buffer overflow.

This sounds to do two things. Two patches please, each with a good
commit message.

> Signed-off-by: Wang Zhimin <wangzhimin1179@...tium.com.cn>
> Signed-off-by: Li Wencheng <liwencheng@...tium.com.cn>
> Signed-off-by: Chen Baozi <chenbaozi@...tium.com.cn>
> Signed-off-by: Wang Yinfeng <wangyinfeng@...tium.com.cn>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>

Five developers for a 25 line patch? Should some of these be
Suggested-by:, Tested-by: Reported-by:?

    Andrew

---
pw-bot: cr