linux-kernel - Re: [PATCH v3] arm64: dts: qcom: x1e80100: Enable tsens and thermal zone nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f171e9f2-0a62-497b-a460-874d5ee1ada3@linaro.org>
Date: Sat, 22 Jun 2024 13:29:56 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Abel Vesa <abel.vesa@...aro.org>, Bjorn Andersson <andersson@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: Johan Hovold <johan@...nel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Rajendra Nayak <quic_rjendra@...cinc.com>
Subject: Re: [PATCH v3] arm64: dts: qcom: x1e80100: Enable tsens and thermal
 zone nodes

On 21.06.2024 9:20 AM, Abel Vesa wrote:
> From: Rajendra Nayak <quic_rjendra@...cinc.com>
> 
> Add tsens and thermal zones nodes for x1e80100 SoC.
> 
> Signed-off-by: Rajendra Nayak <quic_rjendra@...cinc.com>
> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
> ---
> Changes in v3:
> - Changed the upper-lower tsense interrupts to PDC.

I'm still puzzled that the critical irq is not wired up through pdc as
you've said, since it would make a lot of sense that if the thermal subsystem
detects a dangerous situation, the AP would be woken up and the soc would be
then shut down by the OS before any last-moment safety mechanisms (if such
exist) kick in..

Anyway, this looks good now to my brain compiler and the device seems to agree

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
Tested-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad