linux-kernel - Re: [PATCH] drm/amdgpu: fix a possible null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0032d02a-b5ae-452e-b26e-14dc7f091e6b@web.de>
Date: Sat, 22 Jun 2024 16:26:58 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Ma Ke <make24@...as.ac.cn>, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, Alex Deucher <alexander.deucher@....com>,
 Aurabindo Pillai <aurabindo.pillai@....com>,
 Chen Jiahao <chenjiahao16@...wei.com>,
 Christian König <christian.koenig@....com>,
 Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...il.com>,
 Guchun Chen <guchun.chen@....com>,
 Srinivasan Shanmugam <srinivasan.shanmugam@....com>,
 Xinhui Pan <Xinhui.Pan@....com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: fix a possible null pointer dereference

> In amdgpu_connector_add_common_modes(), the return value of drm_cvt_mode()
> is assigned to mode, which will lead to a NULL pointer dereference on
> failure of drm_cvt_mode(). Add a check to avoid npd.

Can a wording approach (like the following) be a better change description?

   A null pointer is stored in the local variable “mode” after a call
   of the function “drm_cvt_mode” failed. This pointer was passed to
   a subsequent call of the function “drm_mode_probed_add” where an undesirable
   dereference will be performed then.
   Thus add a corresponding return value check.

Would you like to add any tags (like “Fixes”) accordingly?

How do you think about to use a summary phrase like “Avoid null pointer dereference
in amdgpu_connector_add_common_modes()”?

Regards,
Markus