linux-kernel - Re: [PATCH] drm/amdgpu: fix a possible null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C5F9411A-0396-4B7F-B6D8-38F2C067283E@froggi.es>
Date: Sun, 23 Jun 2024 10:20:57 +0100
From: Joshua Ashton <joshua@...ggi.es>
To: amd-gfx@...ts.freedesktop.org, Ma Ke <make24@...as.ac.cn>,
 alexander.deucher@....com, christian.koenig@....com, Xinhui.Pan@....com,
 airlied@...il.com, daniel@...ll.ch, srinivasan.shanmugam@....com,
 aurabindo.pillai@....com, make24@...as.ac.cn, guchun.chen@....com,
 chenjiahao16@...wei.com
CC: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: fix a possible null pointer dereference

Are you planning on submitting a bogus CVE for this patch too?

- Joshie 🐸✨

On June 22, 2024 9:22:19 AM GMT+01:00, Ma Ke <make24@...as.ac.cn> wrote:
>In amdgpu_connector_add_common_modes(), the return value of drm_cvt_mode()
>is assigned to mode, which will lead to a NULL pointer dereference on
>failure of drm_cvt_mode(). Add a check to avoid npd.
>
>Signed-off-by: Ma Ke <make24@...as.ac.cn>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>index 9caba10315a8..6cf946adb6fe 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>@@ -458,6 +458,8 @@ static void amdgpu_connector_add_common_modes(struct drm_encoder *encoder,
> 			continue;
> 
> 		mode = drm_cvt_mode(dev, common_modes[i].w, common_modes[i].h, 60, false, false, false);
>+		if (!mode)
>+			continue;
> 		drm_mode_probed_add(connector, mode);
> 	}
> }