linux-kernel - Re: [PATCH] irqchip/loongson-liointc: Set different ISRs for different cores

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 22 Jun 2024 10:25:02 +0800
From: Huacai Chen <chenhuacai@...il.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: Huacai Chen <chenhuacai@...ngson.cn>, loongarch@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn>, 
	Jiaxun Yang <jiaxun.yang@...goat.com>, stable@...r.kernel.org, 
	Tianli Xiong <xiongtianli@...ngson.cn>
Subject: Re: [PATCH] irqchip/loongson-liointc: Set different ISRs for
 different cores

Hi, Thomas,

On Sat, Jun 22, 2024 at 2:40 AM Thomas Gleixner <tglx@...utronix.de> wrote:
>
> On Wed, Jun 12 2024 at 15:01, Huacai Chen wrote:
> > In the liointc hardware, there are different ISRs for different cores.
>
> I have no idea what ISR means in that context. Can you please spell it
> out with proper words so that people not familiar with the details can
> understand it?
ISR means "Interrupt Status Register" here, I will improve the wording.

>
> > We always use core#0's ISR before but has no problem, it is because the
> > interrupts are routed to core#0 by default. If we change the routing,
> > we should set correct ISRs for different cores.
>
> We do nothing. The code does.
>
> See https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#changelog
Let me try my best...

>
> > Cc: <stable@...r.kernel.org>
> > Signed-off-by: Tianli Xiong <xiongtianli@...ngson.cn>
> > Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
>
> This Signed-off-by chain is wrong. If Tianli is the author then this
> needs a From: Tianli in the changelog. If you developed it together then
> this lacks a Co-developed-by tag.
Yes, here we lack a Co-developed-by, thanks.

Huacai

>
> See Documentation/process/
>
> Thanks,
>
>         tglx