linux-kernel - RE: [PATCH 3/6] mei: vsc: Enhance SPI transfer of IVSC rom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 23 Jun 2024 10:42:15 +0000
From: "Wu, Wentong" <wentong.wu@...el.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
CC: "Winkler, Tomas" <tomas.winkler@...el.com>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>, "Chen, Jason Z" <jason.z.chen@...el.com>
Subject: RE: [PATCH 3/6] mei: vsc: Enhance SPI transfer of IVSC rom

> From: Sakari Ailus <sakari.ailus@...ux.intel.com>
> 
> Hi Wentong,
> 
> On Sun, Jun 23, 2024 at 05:30:53PM +0800, Wentong Wu wrote:
> > Constructing the SPI transfer command as per the specific request.
> >
> > Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device")
> > Cc: stable@...r.kernel.org # for 6.8+
> > Signed-off-by: Wentong Wu <wentong.wu@...el.com>
> > Tested-by: Jason Chen <jason.z.chen@...el.com>
> > ---
> >  drivers/misc/mei/vsc-tp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c
> > index 4595b1a25536..7a89e4e5d553 100644
> > --- a/drivers/misc/mei/vsc-tp.c
> > +++ b/drivers/misc/mei/vsc-tp.c
> > @@ -331,7 +331,7 @@ int vsc_tp_rom_xfer(struct vsc_tp *tp, const void
> *obuf, void *ibuf, size_t len)
> >  		return ret;
> >  	}
> >
> > -	ret = vsc_tp_dev_xfer(tp, tp->tx_buf, tp->rx_buf, len);
> > +	ret = vsc_tp_dev_xfer(tp, tp->tx_buf, ibuf ? tp->rx_buf : ibuf,
> > +len);
> 
> Is this correct? I.e. use ibuf when it's NULL, otherwise use tp->rx_buf?

Yes, the SPI framework will adjust this. If ibuf is NULL, but we give tp->rx_buf,
the actual transfer will tx more data than needed.

BR,
Wentong
> 
> >  	if (ret)
> >  		return ret;
> >
> 
> --
> Kind regards,
> 
> Sakari Ailus