linux-kernel - RE: [PATCH 1/6] mei: vsc: Enhance IVSC chipset reset toggling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 23 Jun 2024 10:48:21 +0000
From: "Wu, Wentong" <wentong.wu@...el.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
CC: "Winkler, Tomas" <tomas.winkler@...el.com>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>, "Chen, Jason Z" <jason.z.chen@...el.com>
Subject: RE: [PATCH 1/6] mei: vsc: Enhance IVSC chipset reset toggling

> From: Sakari Ailus <sakari.ailus@...ux.intel.com>
> 
> Hi Wentong,
> 
> Thanks for the set.
>
Hi Sakari,

Thanks for your review

> On Sun, Jun 23, 2024 at 05:30:51PM +0800, Wentong Wu wrote:
> > Implementing the hardware recommendation to toggle the chipset reset.
> >
> > Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device")
> > Cc: stable@...r.kernel.org # for 6.8+
> > Signed-off-by: Wentong Wu <wentong.wu@...el.com>
> > Tested-by: Jason Chen <jason.z.chen@...el.com>
> > ---
> >  drivers/misc/mei/vsc-tp.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c
> > index e6a98dba8a73..dcab5174bf00 100644
> > --- a/drivers/misc/mei/vsc-tp.c
> > +++ b/drivers/misc/mei/vsc-tp.c
> > @@ -350,6 +350,8 @@ void vsc_tp_reset(struct vsc_tp *tp)
> >  	disable_irq(tp->spi->irq);
> >
> >  	/* toggle reset pin */
> > +	gpiod_set_value_cansleep(tp->resetfw, 1);
> > +	msleep(VSC_TP_RESET_PIN_TOGGLE_INTERVAL_MS);
> >  	gpiod_set_value_cansleep(tp->resetfw, 0);
> >  	msleep(VSC_TP_RESET_PIN_TOGGLE_INTERVAL_MS);
> >  	gpiod_set_value_cansleep(tp->resetfw, 1);
> 
> Looking at the patch, the driver appears to leave the reset signal enabled.
> As it currently works, also the polarity appears to be wrong.

Ok, the reset pin is RISING trigger. Probably we can remove this.

> 
> Could you addrss this, after this patch?

ack, I will send v2 patch set.

BR,
Wentong
> 
> --
> Kind regards,
> 
> Sakari Ailus