[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240623131753.2133829-1-make24@iscas.ac.cn>
Date: Sun, 23 Jun 2024 21:17:53 +0800
From: Ma Ke <make24@...as.ac.cn>
To: ast@...nel.org,
daniel@...earbox.net,
andrii@...nel.org,
martin.lau@...ux.dev,
eddyz87@...il.com,
song@...nel.org,
yonghong.song@...ux.dev,
john.fastabend@...il.com,
kpsingh@...nel.org,
sdf@...ichev.me,
haoluo@...gle.com,
jolsa@...nel.org,
mykolal@...com,
shuah@...nel.org,
make24@...as.ac.cn
Cc: bpf@...r.kernel.org,
linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] selftests/bpf: don't close(-1) in serial_test_fexit_stress()
Guard close() with extra link_fd[i] >= 0 and fexit_fd[i] >= 0
check to prevent close(-1).
Signed-off-by: Ma Ke <make24@...as.ac.cn>
---
tools/testing/selftests/bpf/prog_tests/fexit_stress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/fexit_stress.c b/tools/testing/selftests/bpf/prog_tests/fexit_stress.c
index 596536def43d..94ff1d9fc9e4 100644
--- a/tools/testing/selftests/bpf/prog_tests/fexit_stress.c
+++ b/tools/testing/selftests/bpf/prog_tests/fexit_stress.c
@@ -50,9 +50,9 @@ void serial_test_fexit_stress(void)
out:
for (i = 0; i < bpf_max_tramp_links; i++) {
- if (link_fd[i])
+ if (link_fd[i] >= 0)
close(link_fd[i]);
- if (fexit_fd[i])
+ if (fexit_fd[i] >= 0)
close(fexit_fd[i]);
}
free(fd);
--
2.25.1
Powered by blists - more mailing lists