linux-kernel - Re: [PATCH] dmaengine: axi-dmac: Add check for dma_set_max_seg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eaf19171-ef94-4370-a774-1f67d0eb878d@web.de>
Date: Sun, 23 Jun 2024 15:23:40 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Ma Ke <make24@...as.ac.cn>, dmaengine@...r.kernel.org,
 Lars-Peter Clausen <lars@...afoo.de>, Vinod Koul <vkoul@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: axi-dmac: Add check for dma_set_max_seg_size

> To avoid possible failure of the dma_set_max_seg_size(),

Really?

It is desirable to detect a failed function call, isn't it?

> we should better check the return value of the dma_set_max_seg_size().

1. Please choose an imperative wording for an improved change description.
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc4#n94

2. Would you like to add any tags (like “Fixes” and “Cc”) accordingly?

3. How do you think about to append the text “() in axi_dmac_probe()”
   to the summary phrase?

Regards,
Markus