linux-kernel - Re: [PATCH 06/15] net: hbl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 23 Jun 2024 07:25:59 +0000
From: Omer Shpigelman <oshpigelman@...ana.ai>
To: Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
CC: "ogabbay@...nel.org" <ogabbay@...nel.org>,
        Zvika Yehudai
	<zyehudai@...ana.ai>
Subject: Re: [PATCH 06/15] net: hbl_cn: debugfs support

On 6/21/24 13:30, Sunil Kovvuri Goutham wrote:
>>>> +
>>>> +What:           /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_disable_decap
>>>> +What:           /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_inject_rx_err
>>>> +What:
>> /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_mac_lane_remap
>>>
>>> Don't think debugfs is the correct interface for all this configuration.
>>> Debugfs should ideally be used for dumping runtime device state info for debug
>> purposes.
>>>
>>
>> I see other vendors have debugfs entries for debug configurations or settings, not
>> just for dumping debug info.
>>
> 
> But disable_decap / mac_lane_remap seems configuration related which changes the way pkts are processed not debug.
> Configurations are supported via devlink.
> 

As I wrote to Andrew, I'll stick to the debugfs entries that are really
necessary for us.
BTW the entries you mentioned are not regular configurations but advanced
settings to augment debuggability. But yeah, if we can set these via
devlink then it is better to use it.
Let me revisit this for the next patch set version.

> Thanks,
> Sunil.