linux-kernel - Re: [PATCH v7 1/1] nvme-multipath: implement "queue-depth" iopolicy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59921b0a-1e16-4f39-bdda-9e11ba2edbbd@redhat.com>
Date: Mon, 24 Jun 2024 13:50:21 -0400
From: John Meneghini <jmeneghi@...hat.com>
To: Christoph Hellwig <hch@....de>
Cc: kbusch@...nel.org, sagi@...mberg.me, linux-nvme@...ts.infradead.org,
 linux-kernel@...r.kernel.org, emilne@...hat.com, jrani@...estorage.com,
 randyj@...estorage.com, chaitanyak@...dia.com, hare@...nel.org
Subject: Re: [PATCH v7 1/1] nvme-multipath: implement "queue-depth" iopolicy

On 6/24/24 04:46, Christoph Hellwig wrote:
> On Thu, Jun 20, 2024 at 01:54:29PM -0400, John Meneghini wrote:
>> How about:
>>
>> pr_notice("Changed iopolicy from %s to %s for subsysnqn %s\n",
>>                  nvme_iopolicy_names[old_iopolicy],
>>                  nvme_iopolicy_names[iopolicy],
>>                  subsys->subnqn);
> 
> Having the identification as the prefixe seems easier to parse
> and grep for.

To be clear Christoph, your saying you'd like the NQN in the prefix of the dmesg?

E.g.:

root> echo "round-robin" > /sys/class/nvme-subsystem/nvme-subsys11/iopolicy
[Thu Jun 24 11:44:20 2024] subsysnqn nqn.1992-08.com.netapp:sn.2b82d9b13bb211ee8744d039ea989119:subsystem.SS104a iopolicy 
changed from queue-depth to round-robin.

Correct?

/John