linux-kernel - Re: [PATCH] arm: dts: aspeed: Use standard 'i2c' bus node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8dabf3d1-2d23-4adc-a804-2b7aa5fe16e9@kernel.org>
Date: Mon, 24 Jun 2024 06:46:57 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Joel Stanley <joel@....id.au>, "Rob Herring (Arm)" <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Andrew Jeffery <andrew@...econstruct.com.au>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: dts: aspeed: Use standard 'i2c' bus node name

On 24/06/2024 03:55, Joel Stanley wrote:
> On Sat, 1 Jun 2024 at 05:01, Rob Herring (Arm) <robh@...nel.org> wrote:
>>
>> The standard node name for I2C buses is 'i2c'.
> 
> Unfortunately this can't be merged, as it will break userspace. There
> is a lot of code out there that looks up devices based on the device
> tree node path:
> 
> https://github.com/openbmc/phosphor-state-manager/blob/3c1351cc2b63178876ef68f4107c9804d2e17dcc/meson.options#L140

Eh, thanks for sharing.

That's totally stupid user-space. The sysfs path to /sys/devices, or
some grep by compatible, would be fine, but iterating over firmware/DT
is just wrong.

Reminds me USB and ChromeOS. They could fix their userspace, so probably
folks here can as well. I filled a bug.

Best regards,
Krzysztof