linux-kernel - Re: [PATCH v2 3/8] dt-bindings: mips: realtek: Add rtl930x-soc compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 24 Jun 2024 06:48:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>, tglx@...utronix.de,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 tsbogend@...ha.franken.de, daniel.lezcano@...aro.org, paulburton@...nel.org,
 peterz@...radead.org, mail@...ger-koblitz.de, bert@...t.com,
 john@...ozen.org, sander@...nheule.net
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-mips@...r.kernel.org, kabel@...nel.org, ericwouds@...il.com
Subject: Re: [PATCH v2 3/8] dt-bindings: mips: realtek: Add rtl930x-soc
 compatible

On 24/06/2024 03:22, Chris Packham wrote:
> Add the rtl930x-soc and RTL9302C board to the list of Realtek compatible

930x or 9302?

> strings.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
> 
> Notes:
>     Changes in v2:
>     - Use specific compatible for rtl9302-soc
>     - Fix to allow correct board, soc compatible
> 
>  Documentation/devicetree/bindings/mips/realtek-rtl.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mips/realtek-rtl.yaml b/Documentation/devicetree/bindings/mips/realtek-rtl.yaml
> index f8ac309d2994..05daa53417e5 100644
> --- a/Documentation/devicetree/bindings/mips/realtek-rtl.yaml
> +++ b/Documentation/devicetree/bindings/mips/realtek-rtl.yaml
> @@ -20,5 +20,9 @@ properties:
>            - enum:
>                - cisco,sg220-26
>            - const: realtek,rtl8382-soc
> +      - items:
> +          - enum:
> +              - realtek,rtl9302c

Why board has the name of SoC?

> +          - const: realtek,rtl9302-soc

Drop the -soc suffix. The rtl9302 is the soc.

>  
>  additionalProperties: true

Best regards,
Krzysztof