linux-kernel - Re: [PATCH v2 4/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <608b8673-a7d3-4a93-8719-841e451e7ddc@kernel.org>
Date: Mon, 24 Jun 2024 13:45:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jacobe Zang <jacobe.zang@...ion.com>, arend.vanspriel@...adcom.com
Cc: kvalo@...nel.org, duoming@....edu.cn, bhelgaas@...gle.com,
 minipli@...ecurity.net, linux-wireless@...r.kernel.org,
 brcm80211@...ts.linux.dev, brcm80211-dev-list.pdl@...adcom.com, megi@....cz,
 robh@...nel.org, efectn@...tonmail.com, krzk+dt@...nel.org,
 conor+dt@...nel.org, heiko@...ech.de, nick@...das.com, jagan@...eble.ai,
 dsimic@...jaro.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: net: wireless: brcm4329-fmac: add
 clock description.

On 24/06/2024 10:19, Jacobe Zang wrote:
> Add clocks and clock-names for brcm4329-fmac.

Which devices have this clock? All? You now mention driver, but this is
a binding so please describe hardware.

Subject: drop full stops. In every patch.

> 
> Signed-off-by: Jacobe Zang <jacobe.zang@...ion.com>
> ---
>  .../bindings/net/wireless/brcm,bcm4329-fmac.yaml         | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index e564f20d8f415..b9e39a62c3b32 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -121,6 +121,15 @@ properties:
>        NVRAM. This would normally be filled in by the bootloader from platform
>        configuration data.
>  
> +  clocks:
> +    description: phandle to the clock connected on rtc clock line.

Drop redundant parts, like "phandle to the".  Just use items with
description instead of above and maxItems.

> +    maxItems: 1
> +
> +  clock-names:
> +    description: Names of the supplied clocks.

Drop description, completely redundant.

> +    items:
> +      - const: 32k

32k? That's the name of the clock? In the datasheet?

> +
>  required:
>    - compatible
>    - reg

Best regards,
Krzysztof